[cas-dev] AbstractCasFilter server name and sevice URL

[Andrew Petro]

Scott,

> Would that be more clear?

I think it would, as it removes the opportunity to configure both serviceUrl
and serverName and then be unclear on which one takes effect.

Andrew



________________________________________
From: cas-dev-bounces at tp.its.yale.edu
[mailto:cas-dev-bounces at tp.its.yale.edu] On Behalf Of Scott Battaglia
Sent: Monday, December 11, 2006 12:56 PM
To: Mailing list for CAS developers
Subject: Re: [cas-dev] AbstractCasFilter server name and sevice URL

I'd rather not have it "auto-detect" which one you mean as it could get
ambiguous (i.e. is https://localhost:8443/ the url or was someone just being
nice and typing in https)..  I could see the benefit in doing something like


protected AbstractCasFilter(final String service, final boolean
isServerName) which forces you only to configure one but tell us which one
you mean.  Would that be more clear?

-Scott
On 12/4/06, Andrew Petro <apetro at unicon.net> wrote:
* You must specify the serverName (format: hostname:port)
* or the serviceUrl. If you specify both, the
* serviceUrl is used over the serverName.

Is there a reason to support configuring an extraneous serverName, rather 
than requiring that exactly one of these be configured?  Supporting having
both configured and having this rule for which takes precedence makes it
possible to keep around configuration that isn't having any effect, just 
waiting to confuse someone.

I wonder if these configuration parameters can and should be reduced to a
single parameter.  If it is a URL (as determined by the presence of a
scheme:// ), then the exact match requirements of the serviceUrl 
configuration apply.  If it is a hostname (as determined by not being
prefixed by a scheme://) then the autogeneration of service URL from
declared hostname and request path component applies.



_______________________________________________ 
cas-dev mailing list
cas-dev at tp.its.yale.edu
http://tp.its.yale.edu/mailman/listinfo/cas-dev