[cas-dev] JA-SIG CAS client 3.0M1

[Scott Battaglia]

Velpi,

As this release is still in the milestone stages we're open to any
suggestions (and I'm sure things will be renamed too ;-)).  I haven't had
too much time work on it lately though I'm hoping to get back into it
tonight.  Feel free to log JIRA issues for any of your suggestions and a
patch for your additional logging.  I'll take a look at them as soon as
possible.  I have some other ideas I'm working on incorporating also, as
well as cleaning up the TicketValidator API.

Thanks!
-Scott

On 9/22/06, Velpi <velpi at industria.be> wrote:
>
> Hi
>
> I've set up and tested the M1 version of the JA-SIG CAS client the past
> few
> days. It seems to do its job correctly. However I did get to retrieving a
> proxy
> ticket (however the proxy ticket validator seems to work).
> Here are some more remarks and questions:
>
>
> It would be more clean if Cas20ServiceTicketValidator had a constructor
> that
> doesn't require a ProxyGrantingTicketStorage. Is that possible?
> In the same context it might be better to split out the ST and PT
> validator into
> a base abstract class. It's very confusing to see PT stuff in the ST class
> and
> it doesn't feel that clean.
>
> The assembly.xml does not include the examples yet. I think it would be
> nice to
> include a small (demo) webapp directory with some test-jsp and a few
> simple
> examples (simple ST, ST with remote_user filter and authZ, ST&PT). [a
> script
> like http://shib.kuleuven.be/download/sp/test_scripts/shibenv.jsp.txt is
> really
> useful to include]
> It would also be nice if the assembly file xplit out the minimal
> dependencies
> (jar files) that need to be included for using the filter in a webapp.
>
> I suggest a few changes to the properties file to make it more clear:
> --------------
> cas.server.gateway=false
> cas.server.renew=false
> cas.server.url=https://cas.example.be/cas/
> cas.server.loginUrl=${cas.server.url}login
> cas.client.serverName=client.example.be
>
> cas.client.proxyCallbackUrl=https://${cas.client.serverName}/proxy/Receptor
> --------------
> And then use these appropriately in the xml configuration.
>
> The "constructor-arg" is unclear if you don't look at the source code. For
> easier adoption I suggest to put comment with each "constructor-arg" to
> show
> what it's about (and example values).
>
> Is there a reason why the remote_user filter is called
> "HttpServletRequestWrapperFilter" and not
> "CasHttpServletRequestWrapperFilter"?
>
> How should I configure two filters to *eg* a different CAS server that are
> in
> the same context (so the same configuration file...).
>
> I added (more) logging to all the filters. Are you interested in my
> adjustments?
> If yes: would you like diff files or the entire class files? [jira?]
>
>
>
> kind regards,
>
> -- Velpi
> _______________________________________________
> cas-dev mailing list
> cas-dev at tp.its.yale.edu
> http://tp.its.yale.edu/mailman/listinfo/cas-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://tp.its.yale.edu/pipermail/cas-dev/attachments/20060925/aca709ef/attachment.html