[cas-dev] unnecessary syncing in DefaultTicketRegistryCleaner

[March, Andres]

I believe there is unnecessary synchronization in the
DefaultTicketRegistryCleaner.  There are 2 places in clean() where
synchronization occurs but I think it should depend upon the ticket
registry for concurrency.  In fact the two calls that clean() wraps:
getTickets() and deleteTickets() are synchronized in the
DefaultTicketRegistry.  In my implementation of TicketRegistry, I use
BerkeleyDB and delegate to the db for concurrency matters.  This extra
synchronization in the DefaultTicketRegistryCleaner leaves open more
possibility for Deadlocks.  Thoughts?

 

  

Andres March

Platform - Application Engineering

Sony Online Entertainment

desk: 858.577.3373

cell:   619.519.1519

 

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://tp.its.yale.edu/pipermail/cas-dev/attachments/20070221/2f99434d/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/gif
Size: 103 bytes
Desc: image004.gif
Url : http://tp.its.yale.edu/pipermail/cas-dev/attachments/20070221/2f99434d/attachment.gif 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/gif
Size: 73 bytes
Desc: image005.gif
Url : http://tp.its.yale.edu/pipermail/cas-dev/attachments/20070221/2f99434d/attachment-0001.gif 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/gif
Size: 73 bytes
Desc: image006.gif
Url : http://tp.its.yale.edu/pipermail/cas-dev/attachments/20070221/2f99434d/attachment-0002.gif