[cas-dev] CAS 3.1 RC3 Bug in Theme support

[Ronny John]

Hi,

Using CAS 3.1 RC3 I tried to enable theme support to get an individual theme
for my configured services.

First I modify the bean description for bean id="themeResolver" in
cas-servlet.xml (Adding 'p:servicesManager-ref="servicesManager"')

============================================================================
=========
<!-- Theme Resolver -->
<bean id="themeResolver"
class="org.jasig.cas.services.web.ServiceThemeResolver"
    p:defaultThemeName="default"
    p:argumentExtractors-ref="argumentExtractors"
    p:servicesManager-ref="servicesManager" />
============================================================================
=========

Next I try to add a new service (https://localhost/cas/services/add.html).
Hitting "Save Changes" results in the following exception:

java.lang.NullPointerException
	
org.jasig.cas.services.RegisteredServiceImpl.matches(RegisteredServiceImpl.j
ava:101)
	
org.jasig.cas.services.DefaultServicesManagerImpl.findServiceBy(DefaultServi
cesManagerImpl.java:73)
	
org.jasig.cas.services.web.ServiceThemeResolver.resolveThemeName(ServiceThem
eResolver.java:46)
	
org.springframework.web.servlet.support.RequestContextUtils.getTheme(Request
ContextUtils.java:151)
	
org.springframework.web.servlet.support.RequestContext.initContext(RequestCo
ntext.java:236)
	
org.springframework.web.servlet.support.JspAwareRequestContext.initContext(J
spAwareRequestContext.java:75)
	
org.springframework.web.servlet.support.JspAwareRequestContext.<init>(JspAwa
reRequestContext.java:49)
	
org.springframework.web.servlet.tags.RequestContextAwareTag.doStartTag(Reque
stContextAwareTag.java:74)
	
org.apache.jsp.WEB_002dINF.view.jsp.services.add_jsp._jspx_meth_spring_messa
ge_0(add_jsp.java:534)
	
org.apache.jsp.WEB_002dINF.view.jsp.services.add_jsp._jspService(add_jsp.jav
a:94)
	org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
	
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:3
24)
	
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
	org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
	
org.springframework.web.servlet.view.InternalResourceView.renderMergedOutput
Model


Nevertheless my new service has been added to the service registry and the
new theme is working fine. To me there is problem in
"org.jasig.cas.services.RegisteredServiceImpl.matches" which raise a
NullPointerException if there is no specified "?service=" parameter. This
happens, when I just call https://localhost/cas/login/ or when I try to
manage my services (e.g. https://localhost/cas/services/manage.html).

Regards,
Ronny