[cas-dev] ThrottledSubmissionByIpAddressHandlerInterceptorAdapter 3.2.1-SNAPSHOT Bug?

[Robert Oschwald]

I tried to add this to JIRA but always get an error on bug submission (HTTP
Status 404 - No view for result [error] exists for action [ViewIssue])
so I post here:
 
CAS-Version: 3.2.1-SNAPSHOT
 
ThrottledSubmissionByIpAddressHandlerInterceptorAdapter throws a Nullpointer
Exception after login because String.equals is used to determine the
ViewName.
 
Line 84:
if (request.getMethod().equals("GET")
            || !modelAndView.getViewName().equals("casLoginView")) {
            return;
        }
 
After login with a set service param, viewType is a RedirectView (an Object,
not a String)
This causes a NullPointerException in .equals()
Possible Fix: 
|| !StringUtils.equals(viewName, "casLoginView")) {
 
Our setup of the ThrottledSubmissionByIpAddressHandlerInterceptorAdapter in
cas-servlet.xml:
 
 <!-- Handler Mapping -->
 <bean id="handlerMappingB"
class="org.springframework.web.servlet.handler.SimpleUrlHandlerMapping">
  <property
   name="mappings">
   <props>
    <prop key="/login">loginController</prop>
   </props>
  </property>
  <property
   name="interceptors">
   <list>
    <ref bean="throttledSubmissionByIpAddressHandlerInterceptor" />
    <ref bean="localeChangeInterceptor" />
   </list>
  </property>
 </bean>
<bean
 id="throttledSubmissionByIpAddressHandlerInterceptor"
 
class="org.jasig.cas.web.support.ThrottledSubmissionByIpAddressHandlerInterc
eptorAdapter">
 <property name="failureThreshhold" value="100" />
 <property name="failureTimeout" value="60"/>
</bean>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://tp.its.yale.edu/pipermail/cas-dev/attachments/20080318/132bd703/attachment.html